[Bugs] [Bug 1455182] New: ignore incorrect uuid validation in gd_validate_mgmt_hndsk_req

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1455182

            Bug ID: 1455182
           Summary: ignore incorrect uuid validation in
                    gd_validate_mgmt_hndsk_req
           Product: GlusterFS
           Version: 3.10
         Component: glusterd
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: bugs at gluster.org
        Depends On: 1454375
            Blocks: 1455177



+++ This bug was initially created as a clone of Bug #1454375 +++

Description of problem:

In GlusterD's gd_validate_mgmt_hndsk_req () we ignore failure in fetching uuid
from the dictionary to ensure backward compatibility, however the subsequent
check still mandate to use peerid parsed from uuid. More details at
http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-05-22 11:02:16 EDT ---

REVIEW: https://review.gluster.org/17358 (glusterd: ignore incorrect uuid
validation if uuid_str is empty) posted (#1) for review on master by Atin
Mukherjee (amukherj at redhat.com)

--- Additional comment from Worker Ant on 2017-05-23 14:34:40 EDT ---

REVIEW: https://review.gluster.org/17358 (glusterd: ignore incorrect uuid
validation if uuid_str is empty) posted (#2) for review on master by Atin
Mukherjee (amukherj at redhat.com)

--- Additional comment from Worker Ant on 2017-05-24 08:15:10 EDT ---

COMMIT: https://review.gluster.org/17358 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit b1fbc695a63801a3a2c62738fd6660388123724a
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Mon May 22 20:23:06 2017 +0530

    glusterd: ignore incorrect uuid validation if uuid_str is empty

    If uuid_str is not filled up in dictionary (when glusterd bit is old),
    we shouldn't be additional validation with peer uuid otherwise the
    handshake request will fail.

    Refer :
    http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
    Credits : pawan at platform.sh

    Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
    BUG: 1454375
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: https://review.gluster.org/17358
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Amar Tumballi <amarts at redhat.com>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1454375
[Bug 1454375] ignore incorrect uuid validation in
gd_validate_mgmt_hndsk_req
https://bugzilla.redhat.com/show_bug.cgi?id=1455177
[Bug 1455177] ignore incorrect uuid validation in
gd_validate_mgmt_hndsk_req
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.