[Bugs] [Bug 1452705] New: gluster checks presence of version too late

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1452705

            Bug ID: 1452705
           Summary: gluster checks presence of version too late
           Product: GlusterFS
           Version: 3.10
         Component: build
          Assignee: bugs at gluster.org
          Reporter: nh2-redhatbugzilla at deditus.de
                CC: bugs at gluster.org



Description of problem (on gluster 3.10.2):

Some parts of GlusterFS require to know the GlusterFS version in order to
function.

For example, the gverify.sh script used in geo-replication fails if it cannot
determine the version:

https://github.com/gluster/glusterfs/blob/a35bfdaa6279a981a84e8831d65702496f1e478e/geo-replication/src/gverify.sh#L188
https://github.com/gluster/glusterfs/blob/a35bfdaa6279a981a84e8831d65702496f1e478e/geo-replication/src/gverify.sh#L192

The problem is that nothing in the GlusterFS build system checks that a version
is really set.
For example, when downloading a git commit or tag as a tarball from Github
(such as https://github.com/gluster/glusterfs/archive/v3.10.2.tar.gz), then
there is no .git directory, and there is also no VERSION file, but gluster will
happily continue compiling, and `gluster --version` will simply contain
"glusterfs" as the first line of output.

This results in very cryptical error messages late at run-time, for example
when setting up geo-replication, this can result in:

  Staging of operation 'Volume Geo-replication Create' failed on localhost :
Unable to fetch master volume details. Please check the master cluster and
master volume.

when the problem is simply that the version is not set.

The GlusterFS build system should check that the version is set, either by
determining it from .git or from the VERSION file. If none of these 2
approaches have succeeded to determine a version, the build system should fail
loudly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.