[Bugs] [Bug 1451587] New: cli xml status of detach tier broken

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1451587

            Bug ID: 1451587
           Summary: cli xml status of detach tier broken
           Product: GlusterFS
           Version: 3.10
         Component: tiering
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: hgowtham at redhat.com
        QA Contact: bugs at gluster.org
                CC: amukherj at redhat.com, bugs at gluster.org
        Depends On: 1446362



+++ This bug was initially created as a clone of Bug #1446362 +++

Description of problem:
the detach tier status in the xml format is not working properly.

Version-Release number of selected component (if applicable):
3.10 and above

How reproducible:
100%

Steps to Reproduce:
1.create a tiered volume
2.issue detach start
3.issue gluster v tier <volname> detach status --xml

Actual results:
volume detach tier status: success
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>Detach tier status successful</opErrstr>
  <volDetachTier/>
</cliOutput>

Expected results:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>Detach tier status successful</opErrstr>
  <volDetachTier>
    <nodeCount>1</nodeCount>
    <node>
      <nodeName>localhost</nodeName>
      <id>77e903ef-8400-4882-97ae-5a0e326f25b0</id>
      <files>0</files>
      <size>0</size>
      <lookups>0</lookups>
      <failures>0</failures>
      <skipped>0</skipped>
      <status>3</status>
      <statusStr>completed</statusStr>
      <runtime>0.00</runtime>
    </node>
    <aggregate>
      <files>0</files>
      <size>0</size>
      <lookups>0</lookups>
      <failures>0</failures>
      <skipped>0</skipped>
      <status>3</status>
      <statusStr>completed</statusStr>
      <runtime>0.00</runtime>
    </aggregate>
  </volDetachTier>
</cliOutput>

Additional info:

--- Additional comment from Worker Ant on 2017-04-27 14:52:25 EDT ---

REVIEW: https://review.gluster.org/17131 (TIER/CLI: detach status xml output)
posted (#1) for review on master by hari gowtham (hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2017-05-02 00:55:37 EDT ---

REVIEW: https://review.gluster.org/17131 (Tier/cli: detach status xml output)
posted (#2) for review on master by hari gowtham (hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2017-05-04 05:11:06 EDT ---

REVIEW: https://review.gluster.org/17131 (Tier/cli: detach status xml output)
posted (#3) for review on master by hari gowtham (hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2017-05-17 01:07:43 EDT ---

COMMIT: https://review.gluster.org/17131 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 2592fa0409d5215473b84012c69ac34d0270ef08
Author: hari gowtham <hgowtham at redhat.com>
Date:   Fri Apr 28 00:09:50 2017 +0530

    Tier/cli: detach status xml output

    Problem: detach status xml output was broken because
    of the wrong argument. The status_op sent to verify
    whether it is a tier status command was as false.

    Fix: the argument being passed was changed from false
    to true.

    Change-Id: I8cdd4dd972d6bfbb61c1182cbf4097767f83c7c5
    BUG: 1446362
    Signed-off-by: hari gowtham <hgowtham at redhat.com>
    Reviewed-on: https://review.gluster.org/17131
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Tested-by: hari gowtham <hari.gowtham005 at gmail.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-by: N Balachandran <nbalacha at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1446362
[Bug 1446362] cli xml status of detach tier broken
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.