[Bugs] [Bug 1451434] New: Use a bitmap to store local node info instead of conf-> local_nodeuuids[i].uuids

bugzilla at redhat.com bugzilla at redhat.com
Tue May 16 15:59:20 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1451434

            Bug ID: 1451434
           Summary: Use a bitmap to store local node info instead of
                    conf->local_nodeuuids[i].uuids
           Product: GlusterFS
           Version: mainline
         Component: distribute
          Assignee: bugs at gluster.org
          Reporter: nbalacha at redhat.com
                CC: bugs at gluster.org



Description of problem:
>From Jeff Darcy's review:

"Do we really need to gf_uuid_compare here?  What if, instead of storing the
complete list of UUIDs for each replica set, we instead stored a bitmap of
which replicas were local?  Then this comparison would look more like this.
   if ((1 << index) && conf->local_replicas_mask)
Because the bitmap would be more compact, this might also ease worries about
dynamic memory allocation etc."

...

"I'm just keenly aware that this is likely to be a frequently executed code
path - there could be millions of files to be rebalance - so extra loops need
to be carefully considered.  If they're justified, great, so long as they're
considered."

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list