[Bugs] [Bug 1450546] New: Paths to some tools are hardcoded to /sbin or /usr/sbin

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1450546

            Bug ID: 1450546
           Summary: Paths to some tools are hardcoded to /sbin or
                    /usr/sbin
           Product: GlusterFS
           Version: 3.10
         Component: core
          Assignee: bugs at gluster.org
          Reporter: nh2-redhatbugzilla at deditus.de
                CC: bugs at gluster.org



Description of problem (using gluster 3.10.1):

In some places, Gluster hardcodes locations to lookup tools like xfs_info and
tune2fs to looking them up in /sbin or /usr/sbin (see e.g.
https://github.com/gluster/glusterfs/blob/9dc37dd8aa57bea5b86ac4f2a44e31106aeb58ad/xlators/mgmt/glusterd/src/glusterd-utils.c#L6088).

This is inconsistent with calls to other tools that Gluster does, where it does
not hardcode, and instead relies on PATH, which makes sense (especially since
/sbin and /usr/sbin are typically already on PATH).

Hardcoding paths makes problems on distributions where e.g. xfs_info are not in
/sbin or /usr/sbin (for example NixOS), and also makes it harder to let gluster
use instrumented tools e.g. for logging purposes.

I think that gluster should not hardcode such paths, but consistently rely on
them being in PATH, as it does in many other instances.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.