[Bugs] [Bug 1450267] nl-cache xlator leaks timer wheel and other memory

bugzilla at redhat.com bugzilla at redhat.com
Fri May 12 13:32:35 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1450267



--- Comment #3 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17262 committed in release-3.11 by
Shyamsundar Ranganathan (srangana at redhat.com) 
------
commit 45a5cea1ad028bdff5f33770df8ecdd9ac69b6f1
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon Apr 17 15:50:07 2017 +0530

    core: make the per glusterfs_ctx_t timer-wheel refcounted

    xlators can use a 'global' timer-wheel for scheduling events. This
    timer-wheel is managed per glusterfs_ctx_t, but does not need to be
    allocated for every graph. When an xlator wants to use the timer-wheel,
    it will be instanciated on demand, and provided to xlators that request
    it later on.

    By adding a reference counter to the glusterfs_ctx_t for the
    timer-wheel, the threads and structures can be cleaned up when the last
    xlator does not have a need for it anymore. In general, the xlators
    request the timer-wheel in init(), and they should return it in fini().

    Because the timer-wheel is managed per glusterfs_ctx_t, the functions
    can be added to ctx.c and do not need to live in their very minimal
    tw.[ch] files.


    >Reported-by: Poornima G <pgurusid at redhat.com>
    >Signed-off-by: Niels de Vos <ndevos at redhat.com>
    >Reviewed-on: https://review.gluster.org/17068
    >NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    >CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    >Smoke: Gluster Build System <jenkins at build.gluster.org>
    >Reviewed-by: Amar Tumballi <amarts at redhat.com>
    >Reviewed-by: Zhou Zhengping <johnzzpcrystal at gmail.com>
    >Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    >(cherry picked from commit 73fcf3a874b2049da31d01b8363d1ac85c9488c2)

    Change-Id: I19d225b39aaa272d9005ba7adc3104c3764f1572
    BUG: 1450267
    Reviewed-on: https://review.gluster.org/17262
    Tested-by: Poornima G <pgurusid at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OisGFQEZ5J&a=cc_unsubscribe


More information about the Bugs mailing list