[Bugs] [Bug 1448864] New: Seeing error " Failed to get the total number of files. Unable to estimate time to complete rebalance " in rebalance logs

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1448864

            Bug ID: 1448864
           Summary: Seeing error "Failed to get the total number of files.
                    Unable to estimate time to complete rebalance" in
                    rebalance logs
           Product: GlusterFS
           Version: 3.10
         Component: distribute
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: nbalacha at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    rhinduja at redhat.com, tdesala at redhat.com
        Depends On: 1446165, 1448640



+++ This bug was initially created as a clone of Bug #1448640 +++

+++ This bug was initially created as a clone of Bug #1446165 +++

Description of problem:
=======================
Seeing error "Failed to get the total number of files. Unable to estimate time
to complete rebalance" in rebalance logs

Version-Release number of selected component (if applicable):
3.8.4-24.el7rhgs.x86_64

How reproducible:
1/1

Steps to Reproduce:
===================
1) Create a distributed-replicate volume and start it.
2) FUSE mount on a client.
3) Add few bricks and start rebalance. (This error is seen during remove-brick
as well)

Note: This error says it is unable to estimate the time to complete rebalance
but we are able to see the rebalance estimate time during add-brick or
remove-brick rebalance.

Actual results:
===============
Seeing error "Failed to get the total number of files. Unable to estimate time
to complete rebalance" in rebalance logs

Expected results:
=================
We should not see error "Failed to get the total number of files. Unable to
estimate time to complete rebalance" in rebalance logs.


--- Additional comment from Nithya Balachandran on 2017-05-02 23:49:08 EDT ---

This is a bug:


In dht-rebalance.c:


ret = gf_defrag_total_file_cnt (this, &loc);                    
if (!ret) {                                                     
        gf_msg (this->name, GF_LOG_ERROR, 0, 0, "Failed to get "
                "the total number of files. Unable to estimate "
                "time to complete rebalance.");                 
}   

This should be 

if (ret) {
 ...

}

--- Additional comment from Worker Ant on 2017-05-06 10:32:42 EDT ---

REVIEW: https://review.gluster.org/17197 (cluster/dht Fix ret check) posted
(#1) for review on master by N Balachandran (nbalacha at redhat.com)

--- Additional comment from Worker Ant on 2017-05-08 00:04:02 EDT ---

REVIEW: https://review.gluster.org/17197 (cluster/dht: Fix ret check) posted
(#2) for review on master by N Balachandran (nbalacha at redhat.com)

--- Additional comment from Worker Ant on 2017-05-08 00:47:40 EDT ---

COMMIT: https://review.gluster.org/17197 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 67598f538efb24a9e5ac561b294a05e707e15761
Author: N Balachandran <nbalacha at redhat.com>
Date:   Sat May 6 20:01:16 2017 +0530

    cluster/dht: Fix ret check

    Fixed an incorrect return code check in the rebalance
    code.

    Change-Id: I60804ff121cec7a2f0419e2ee70dd22ea7533c0c
    BUG: 1448640
    Signed-off-by: N Balachandran <nbalacha at redhat.com>
    Reviewed-on: https://review.gluster.org/17197
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1446165
[Bug 1446165] Seeing error "Failed to get the total number of files. Unable
to estimate time to complete rebalance" in rebalance logs
https://bugzilla.redhat.com/show_bug.cgi?id=1448640
[Bug 1448640] Seeing error "Failed to get the total number of files. Unable
to estimate time to complete rebalance" in rebalance logs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.