[Bugs] [Bug 1424817] Fix wrong operators, found by coverty

bugzilla at redhat.com bugzilla at redhat.com
Thu May 4 14:58:20 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1424817



--- Comment #3 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16676 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit 5c68937ef943a5ed8179cb19fef833f2be790588
Author: Michael Scherer <misc at redhat.com>
Date:   Sun Feb 19 17:19:33 2017 +0100

    Fix wrong operators

    Coverty rightfully note that if we verify that
    A =! C or A != B, it will always be true.

    In one case, that prevent healing from continuing. In the other,
    that trigger useless logs. Fixing this bug also show that
    ENOSPC shouldn't abort the rebalance operation, as seen during
    the review of the first patch on
   
https://review.gluster.org/#/c/16676/1/xlators/cluster/dht/src/dht-rebalance.c

    Change-Id: I93c4df43b880b211da202a7e49cef6b1ce7ab68f
    BUG: 1424817
    Signed-off-by: Michael Scherer <misc at redhat.com>
    Reviewed-on: https://review.gluster.org/16676
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>
    Tested-by: Jeff Darcy <jeff at pl.atyp.us>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Amar Tumballi <amarts at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aQSwovYjsY&a=cc_unsubscribe


More information about the Bugs mailing list