[Bugs] [Bug 1442569] Implement Negative lookup cache feature to improve create performance

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1442569



--- Comment #15 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17143 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit d7e9dcfad228f385ad64526b1f06b55e98b06964
Author: Niels de Vos <ndevos at redhat.com>
Date:   Fri Apr 21 18:36:58 2017 +0200

    nl-cache: free nlc_conf_t in fini()

    The (xlator_t*)->private structure in negative-lookup-cache is allocated
    in the init() function of the xlator, but never free'd. Valgrind
    detected this as:

        656 bytes in 1 blocks are definitely lost in loss record X of Y
           at 0x..+ calloc
(/builddir/build/BUILD/valgrind-3.11.0/coregrind/m_replacemalloc/vg_replace_malloc.c:711)
           by 0x.. __gf_calloc
(/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/mem-pool.c:117)
           by 0x.. init
(/usr/src/debug/glusterfs-3.11dev/xlators/performance/nl-cache/src/nl-cache.c:669)
           by 0x.. __xlator_init
(/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/xlator.c:472)
           by 0x.. xlator_init
(/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/xlator.c:498)
           by 0x.. glusterfs_graph_init
(/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/graph.c:321)
           by 0x.. glusterfs_graph_activate
(/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/graph.c:693)
           by 0x.. glfs_process_volfp
(/usr/src/debug/glusterfs-3.11dev/api/src/glfs-mgmt.c:79)
           by 0x.. glfs_volumes_init
(/usr/src/debug/glusterfs-3.11dev/api/src/glfs.c:160)
           by 0x.. glfs_init_common
(/usr/src/debug/glusterfs-3.11dev/api/src/glfs.c:868)
           by 0x.. glfs_init@@GFAPI_3.4.0
(/usr/src/debug/glusterfs-3.11dev/api/src/glfs.c:913)
           by 0x.. main
(/root/gluster-debug/gfapi-load-volfile/gfapi-load-volfile.c:54)

    When the xlators is unloaded, it should free the resources it allocated.
    This can easily be done in the fini() function.

    Change-Id: I079e78cc207145bc542e2282fc4cf2bb4dadc28a
    BUG: 1442569
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: https://review.gluster.org/17143
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nd87gd8DKa&a=cc_unsubscribe