[Bugs] [Bug 1434274] BZ for some bugs found while going through synctask code

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1434274



--- Comment #14 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16951 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit df189a8644d7a805bb3e278f61983c5ba8619188
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Mon Mar 27 07:19:57 2017 +0530

    syncop: Fix args for makecontext

    Passing 64bit arguments to makecontext is not portable and manpage says the
following:

    <snip>
    On  architectures where int and pointer types are the same size (e.g.,
x86-32, where
    both types are 32 bits), you may be able to get away with passing pointers
as  argu‐
    ments  to makecontext() following argc.  However, doing this is not
guaranteed to be
    portable, is undefined according to the standards, and won't work  on 
architectures
    where pointers are larger than ints.  Nevertheless, starting with version
2.8, glibc
    makes some changes to makecontext(), to permit this  on  some  64-bit 
architectures
    (e.g., x86-64).
    </snip>

    Since we do not depend on the arguments, it is better to change makecontext
to not
    take any arguments.

    BUG: 1434274
    Change-Id: Ic46c9e9faaeb2f78e4efde353ef861466515b1ec
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: https://review.gluster.org/16951
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3EMpL1ETE4&a=cc_unsubscribe