[Bugs] [Bug 1427759] New: nfs-ganesha: Incorrect error message returned when disable fails

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1427759

            Bug ID: 1427759
           Summary: nfs-ganesha: Incorrect error message returned when
                    disable fails
           Product: GlusterFS
           Version: 3.10
         Component: glusterd
          Severity: medium
          Assignee: jthottan at redhat.com
          Reporter: jthottan at redhat.com
                CC: asoman at redhat.com, bugs at gluster.org,
                    rhinduja at redhat.com, rhs-bugs at redhat.com,
                    sbhaloth at redhat.com, skoduri at redhat.com,
                    storage-qa-internal at redhat.com, vbellur at redhat.com



+++ This bug was initially created as a clone of Bug #1427452 +++

Description of problem:

At times. running "gluster nfs-ganesha disable" fails with below error message
-

]# gluster nfs-ganesha disable
Disabling NFS-Ganesha will tear down entire ganesha cluster across the trusted
pool. Do you still want to continue?
 (y/n) y
This will take a few minutes to complete. Please wait ..
nfs-ganesha: failed: nfs-ganesha is already (null)d.
# 


Here in the above error message, instead of "disabled" the string contains
"(null)d". Jiffin and myself found that this issue happens mostly when this
command was run without enabling nfs-ganesha global option even once in the
storage pool setup.

The issue is with de-referencing NULL string in glusterd_op_stage_set_ganesha()
 when priv->opts dict doesn't contain global key.

Version-Release number of selected component (if applicable):
3.10

How reproducible:
Fairly

Steps to Reproduce:
1. On a fresh setup, without enabling NFS-Ganesha, try running disable command.

Actual results:
The error message contain invalid string.

Expected results:
The error message should be proper.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DMVsizJQiC&a=cc_unsubscribe