[Bugs] [Bug 789278] Issues reported by Coverity static analysis tool

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 1 04:29:41 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=789278



--- Comment #859 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16738 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit bae7b51d628a3ff4d96be1ec62dca1c8ed008dc8
Author: Michael Scherer <misc at redhat.com>
Date:   Thu Feb 23 20:17:25 2017 +0100

    Use int instead of int8_t for the 3 variables

    Since strcmp return a int, and since the spec
    of strcmp do not tell the return value, it
    could return 256 and this would overflow.

    Found by Coverity scan.
    (thanks to Stéphane Marcheusin who explained
    the details to me)

    Change-Id: I5195e05b44f8b537226e6cee178d95a1ab904e96
    BUG: 789278
    Signed-off-by: Michael Scherer <misc at redhat.com>
    Reviewed-on: https://review.gluster.org/16738
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    Tested-by: Michael Scherer <misc at fedoraproject.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Bugs mailing list