[Bugs] [Bug 1417606] OOM kill of glusterfsd during continuous add-bricks

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1417606



--- Comment #3 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16480 committed in release-3.9 by Niels de
Vos (ndevos at redhat.com) 
------
commit 4852ca54db76ed36a5b68d4b492b8165bff403bd
Author: Mohit Agrawal <moagrawa at redhat.com>
Date:   Fri Jan 13 12:17:05 2017 +0530

    upcall: Resolve dict leak from up_(f)removexattr in upcall code path

    Problem: In up_(f)removexattr() dict_for_key_value() is used to create a
             new dict. This dict is not correctly unref'd and gets leaked.

    Solution: To avoid the leak up_(f)removexattr() now also does a
              dict_unref() on the newly created dict.

    While reviewing the code in up_(f)setxattr() for a similar problem, it
    was noticed that there is an extra dict created. There is no need for
    this copy, upcall_local_init() can just take the dict that was passed as
    argument to the FOP.

    > BUG: 1412917
    > Change-Id: I5bb9a7d99f5087af11c19ae722de62bdb5ad1498
    > Signed-off-by: Mohit Agrawal <moagrawa at redhat.com>
    > Reviewed-on: http://review.gluster.org/16392
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Niels de Vos <ndevos at redhat.com>
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > (cherry picked from commit afdd83a9b69573b854e732795c0bcba0a00d6c0f)

    Change-Id: I0a53545528c43c09b88d360d3a12c460476647ba
    BUG: 1417606
    Signed-off-by: Mohit Agrawal <moagrawa at redhat.com>
    Reviewed-on: https://review.gluster.org/16480
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.