[Bugs] [Bug 1416285] EXPECT_WITHIN is taking too much time even if the result matches with expected value

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1416285



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16467 committed in release-3.10 by
Shyamsundar Ranganathan (srangana at redhat.com) 
------
commit 10076acaddfa611214e42e0402c3578bc69cada9
Author: Ashish Pandey <aspandey at redhat.com>
Date:   Thu Jan 12 14:48:28 2017 +0530

    tests/include : EXPECT_WITHIN takes full time even if expression matches

    Problem: For all the tests using get_pending_heal_count, EXPECT_WITHIN
    is taking full time given to it even if the heal count matches with
    expected value.

    Solution:
    RC - In most of the tests, to check heal count, wildcards are
    being used. In EXPECT_WITHIN, in if condition, when we use it in
    double quotes (" "), it gives string with wildcards which does not
    match with the output of get_pending_heal_count.
    For example, (0 =~ ^0$).
    So, "while" loop was running for full time and at the end, after
    coming out of loop, in next if condition it was matching with the
    expression without quotes. That is why it was passing.

    Remove double quotes in "if condition" in EXPECT_WITHIN and match
    as we are matching it in test_expect_footer.

    >Change-Id: Ia161594774d05b9b888efb2f7ed1950590d8ac1b
    >BUG: 1412549
    >Signed-off-by: Ashish Pandey <aspandey at redhat.com>
    >Reviewed-on: https://review.gluster.org/16382
    >Smoke: Gluster Build System <jenkins at build.gluster.org>
    >Reviewed-by: Jeff Darcy <jdarcy at redhat.com>
    >NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    >CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    >Reviewed-by: Raghavendra Talur <rtalur at redhat.com>
    >Signed-off-by: Ashish Pandey <aspandey at redhat.com>

    Change-Id: Ia161594774d05b9b888efb2f7ed1950590d8ac1b
    BUG: 1416285
    Signed-off-by: Ashish Pandey <aspandey at redhat.com>
    Reviewed-on: https://review.gluster.org/16467
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gD8Fux2QS5&a=cc_unsubscribe