[Bugs] [Bug 1415581] New: RFE : Create trash directory only when its is enabled

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1415581

            Bug ID: 1415581
           Summary: RFE : Create trash directory only when its is enabled
           Product: GlusterFS
           Version: 3.10
         Component: trash-xlator
          Keywords: FutureFeature, Triaged
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: anoopcs at redhat.com
                CC: anoopcs at redhat.com, bugs at gluster.org,
                    jthottan at redhat.com, riehecky at fnal.gov,
                    vbellur at redhat.com
        Depends On: 1264849
            Blocks: 1319485, 1324531



+++ This bug was initially created as a clone of Bug #1264849 +++

Description of problem:

The creation of trash directory will performed only when it is enabled. And
similarly operations such as rename , deletion will be prevented only when it
is enabled. If creation fails (by some how) then trash xlator will off by
throwing a warning message. The same is applicable for internal op directory.

--- Additional comment from Vijay Bellur on 2015-10-12 18:30:59 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash : create trash
directory only when it is enabled) posted (#2) for review on master by jiffin
tony Thottan (jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-28 15:14:13 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash : create trash
directory only when it is enabled) posted (#3) for review on master by jiffin
tony Thottan (jthottan at redhat.com)

--- Additional comment from Mike McCune on 2016-03-29 04:20:27 IST ---

This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see mmccune at redhat.com with any questions

--- Additional comment from Niels de Vos on 2016-05-10 15:02:09 IST ---

This didnt make it for GlusterFS 3.8, moving out of the tracking tree.

--- Additional comment from Worker Ant on 2016-08-30 01:39:42 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash : create trash
directory only when it is enabled) posted (#4) for review on master by jiffin
tony Thottan (jthottan at redhat.com)

--- Additional comment from Worker Ant on 2016-08-30 12:20:58 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash : create trash
directory only when it is enabled) posted (#5) for review on master by jiffin
tony Thottan (jthottan at redhat.com)

--- Additional comment from Worker Ant on 2016-12-14 15:03:07 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash: Create trash directory
only when it is enabled) posted (#6) for review on master by Anoop C S
(anoopcs at redhat.com)

--- Additional comment from Worker Ant on 2016-12-21 11:07:43 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash: Create trash directory
only when it is enabled) posted (#7) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Worker Ant on 2016-12-22 10:58:40 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash: Create trash directory
only when it is enabled) posted (#8) for review on master by Anoop C S
(anoopcs at redhat.com)

--- Additional comment from Worker Ant on 2017-01-17 12:31:45 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash: Create trash directory
only when it is enabled) posted (#9) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Worker Ant on 2017-01-18 18:09:28 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash: Create trash directory
only when it is enabled) posted (#10) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Worker Ant on 2017-01-19 20:46:03 IST ---

REVIEW: http://review.gluster.org/12256 (features/trash: Create trash directory
only when it is enabled) posted (#11) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Worker Ant on 2017-01-20 17:42:25 IST ---

COMMIT: http://review.gluster.org/12256 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 07b9853ad0c92b341be33a6cd632013c416221c8
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Mon Sep 28 17:20:19 2015 +0530

    features/trash: Create trash directory only when it is enabled

    Previously trash directory was being created as part of volume
    start operation. And also the user/admin could not delete this
    directory from volume even if it is not needed. This patch will
    fix the same. From now onwards creation and enforcement on trash
    directory will come into pictrure only when trash translator is
    enabled. Similarly exact same behaviour is reflected on internal-op
    directory inside trash directory.

    Change-Id: I3e58316a7b299a691885e458c960438bec2220fb
    BUG: 1264849
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: http://review.gluster.org/12256
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Tested-by: Anoop C S <anoopcs at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1264849
[Bug 1264849] RFE : Create trash directory only when its is enabled
https://bugzilla.redhat.com/show_bug.cgi?id=1319485
[Bug 1319485] [Tracker] Trash feature improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1324531
[Bug 1324531] RFE : Create trash directory only when its is enabled
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.