[Bugs] [Bug 1414655] New: Upcall: Possible memleak if inode_ctx_set fails

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1414655

            Bug ID: 1414655
           Summary: Upcall: Possible memleak if inode_ctx_set fails
           Product: GlusterFS
           Version: 3.8
         Component: upcall
          Keywords: Triaged
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: skoduri at redhat.com
                CC: bugs at gluster.org
        Depends On: 1412489
            Blocks: 1414654



+++ This bug was initially created as a clone of Bug #1412489 +++

Description of problem:

In __upcall_inode_ctx_set() if __inode_ctx_set() fails, we should be freeing
the allocated inode_ctx. That's not the case now. Thanks Nithya for the
pointer.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-01-12 03:53:34 EST ---

REVIEW: http://review.gluster.org/16381 (Upcall: Fix possible memleak when
inode_ctx_set fails) posted (#1) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Worker Ant on 2017-01-12 10:47:27 EST ---

COMMIT: http://review.gluster.org/16381 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 84271e12efb783bfc83133329b0fd18aba729c84
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Thu Jan 12 14:19:31 2017 +0530

    Upcall: Fix possible memleak when inode_ctx_set fails

    In __upcall_inode_ctx_set(), if inode_ctx_set fails we should
    free allocated memory for ctx. This patch takes care of the same.

    Change-Id: Iafb42787151a579caf6f396c9b414ea48d16e6b4
    BUG: 1412489
    Reported-by: Nithya Balachandran <nbalacha at redhat.com>
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/16381
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1412489
[Bug 1412489] Upcall: Possible memleak if inode_ctx_set fails
https://bugzilla.redhat.com/show_bug.cgi?id=1414654
[Bug 1414654] Upcall: Possible memleak if inode_ctx_set fails
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.