[Bugs] [Bug 1412941] Regression caused by enabling client-io-threads by default

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1412941



--- Comment #5 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/16397 committed in release-3.8 by Pranith
Kumar Karampuri (pkarampu at redhat.com) 
------
commit 2cfb7bc2419bbd38eaec070fbd2c874dd748f16b
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Fri Nov 18 13:30:08 2016 +0530

    performance/io-threads: Exit threads in fini() as well

    Problem:
    io-threads starts the thread in 'init()' but doesn't clean them up
    on 'fini()'. It relies on PARENT_DOWN to exit threads but there can
    be cases where event before PARENT_UP the graph init code can think
    of issuing fini(). This code path is hit when glfs_init() is called
    on a volume that is in 'stopped' state. It leads to a crash in ganesha
    process, because the io-thread tries to access freed memory.

    Fix:
    Ideal fix would be to wait for all fops in io-thread list to be completed
on
    PARENT_DOWN, and have fini() do cleanup of threads. Because there is no
proper
    documentation about how PARENT_DOWN/fini are supposed to be used,
    we are getting different kinds of sequences in different higher level
protocols.
    So for now cleaning up in both PARENT_DOWN and fini(). Fuse doesn't call
fini()
    gfapi is not calling PARENT_DOWN in some cases, so for now I don't see
    another way out.

     >BUG: 1396793
     >Change-Id: I9c9154e7d57198dbaff0f30d3ffc25f6d8088aec
     >Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
     >Reviewed-on: http://review.gluster.org/15888
     >Smoke: Gluster Build System <jenkins at build.gluster.org>
     >CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
     >NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
     >Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
     >(cherry picked from commit 25817a8c868b6c1b8149117f13e4216a99e453aa)

    BUG: 1412941
    Change-Id: I5e36a7d253f2ef8abce507eced1eb7073cff930c
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/16397
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.