[Bugs] [Bug 1412888] Extra lookup/ fstats are sent over the network when a brick is down.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1412888



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/16386 committed in release-3.8 by Pranith
Kumar Karampuri (pkarampu at redhat.com) 
------
commit 7969610cd129dacf3074dfec67abf1871e04c82c
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri Dec 30 14:57:17 2016 +0530

    afr: Avoid resetting event_gen when brick is always down

    Problem:
    __afr_set_in_flight_sb_status(), which resets event_gen to zero, is
    called if failed_subvols[i] is non-zero for any brick. But
failed_subvols[i]
    is true even if the brick was down *before* the transaction started.
    Hence say if 1 brick is down in  a replica-3, every writev that comes
    will trigger an inode refresh because of this resetting, as seen from
    the no. of FSTATs in the profile info in the BZ.

    Fix:
    Reset event gen only if the brick was previously a valid read child and
    the FOP failed on it the first time.

    Also `s/afr_inode_read_subvol_reset/afr_inode_event_gen_reset` because
    the function only resets event gen and not the data/metadata readable.

    > Reviewed-on: http://review.gluster.org/16309
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    > Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    (cherry picked from commit 522640be476a3f97dac932f7046f0643ec0ec2f2)

    Change-Id: I603ae646cbde96995c35db77916e2ed80b602a91
    BUG: 1412888
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/16386
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xQa6YZPLf3&a=cc_unsubscribe