[Bugs] [Bug 1412890] Extra lookup/ fstats are sent over the network when a brick is down.

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 14 04:00:00 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1412890



--- Comment #3 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/16387 committed in release-3.7 by Pranith
Kumar Karampuri (pkarampu at redhat.com) 
------
commit ef341819eaedb703bc2f7bc1cd2e5ac855fed42b
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri Jan 13 09:55:49 2017 +0530

    afr: Avoid resetting event_gen when brick is always down

    Backport of http://review.gluster.org/#/c/16309/

    Problem:
    __afr_set_in_flight_sb_status(), which resets event_gen to zero, is
    called if failed_subvols[i] is non-zero for any brick. But
failed_subvols[i]
    is true even if the brick was down *before* the transaction started.
    Hence say if 1 brick is down in  a replica-3, every writev that comes
    will trigger an inode refresh because of this resetting, as seen from
    the no. of FSTATs in the profile info in the BZ.

    Fix:
    Reset event gen only if the brick was previously a valid read child and
    the FOP failed on it the first time.

    Also `s/afr_inode_read_subvol_reset/afr_inode_event_gen_reset` because
    the function only resets event gen and not the data/metadata readable.

    Change-Id: I7840f7123d3b3e0404743988088ec349391ca980
    BUG: 1412890
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/16387
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kdT9AAxLMr&a=cc_unsubscribe


More information about the Bugs mailing list