[Bugs] [Bug 1406411] Add-brick command fails when one of the replica brick is down

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1406411



--- Comment #11 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/16330 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit c916a2ffc257b0cfa493410e31b6af28f428c53a
Author: karthik-us <ksubrahm at redhat.com>
Date:   Thu Jan 5 14:06:21 2017 +0530

    glusterd: Fail add-brick on replica count change, if brick is down

    Problem:
    1. Have a replica 2 volume with bricks b1 and b2
    2. Before setting the layout, b1 goes down
    3. Set the layout write some data, which gets populated on b2
    4. b2 goes down then b1 comes up
    5. Add another brick b3, and heal will take place from b1 to b3, which
       basically have no data
    6. Write some data. Both b1 and b3 will mark b2 for pending writes
    7. b1 goes down, and b2 comes up
    8. b2 gets heald from b1. During heal it removes the data which is already
       in b2, considering that as stale data. This leads to data loss.

    Solution:
    1. In glusterd stage-op, while adding bricks, check whether the replica
       count is being increased
    2. If yes, then check whether any of the bricks are down at that time
    3. If yes, then fail the add-brick to avoid such data loss
    4. Else continue the normal operation.

    This check will work enen when we convert plain distribute volume to
replicate

    Test:
    1. Create a replica 2 volume
    2. Kill one brick from the volume
    3. Try adding a brick to the volume
    4. It should fail with all bricks are not up error
    5. Cretae a distribute volume and kill one of the brick
    6. Try to convert it to replicate volume, by adding bricks.
    7. This should also fail.

    Change-Id: I9c8d2ab104263e4206814c94c19212ab914ed07c
    BUG: 1406411
    Signed-off-by: karthik-us <ksubrahm at redhat.com>
    Reviewed-on: http://review.gluster.org/16330
    Tested-by: Ravishankar N <ravishankar at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NXQYOMRcvh&a=cc_unsubscribe