[Bugs] [Bug 1405301] Fix the failure in tests/basic/gfapi/bug1291259.t

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1405301

Niels de Vos <ndevos at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ndevos at redhat.com



--- Comment #7 from Niels de Vos <ndevos at redhat.com> ---
Hmm, I did send something like that before already. From the email thread:

  http://www.gluster.org/pipermail/gluster-devel/2016-December/051721.html

--
On Wed, Dec 14, 2016 at 10:30:46AM +0100, Niels de Vos wrote:
> On Wed, Dec 14, 2016 at 04:10:38AM -0500, Poornima Gurusiddaiah wrote:
> > Oh ok. I see that in ./tests/basic/gfapi/bug1291259.c the function
> > glfs_upcall_get_reason() is causing segmentation fault, as per the
> > stderr messages. 
> > Adding Niels, if he wants to take a look at this. 
> 
> glfs_upcall_get_reason() can only segfault if the parameter it passes is
> NULL. It seems that it is possible to get a successful return value from
> glfs_h_poll_upcall(), setting a NULL value for the object with the
> details:
> 
>   https://github.com/gluster/glusterfs/blob/master/api/src/glfs-handleops.c#L2076
> 
> The test-case (and maybe others too?) should not only check for the
> return value from glfs_h_poll_upcall(), but also the errno (!ENOENT).
> 
> > We can mark the test bad by raising a Bz i suppose. 
> 
> Has a bug been filed for this test-case yet?

http://review.gluster.org/16131 is a patch for testing, on top of #16046
in the release-3.9 branch from Krutika. Lets see if this passes :)

Niels

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cirPZySShb&a=cc_unsubscribe