[Bugs] [Bug 1425695] New: [Geo-rep] If for some reason MKDIR failed to sync, it should not proceed further.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1425695

            Bug ID: 1425695
           Summary: [Geo-rep] If for some reason MKDIR failed to sync, it
                    should not proceed further.
           Product: Red Hat Gluster Storage
           Version: 3.2
         Component: geo-replication
          Assignee: avishwan at redhat.com
          Reporter: khiremat at redhat.com
        QA Contact: rhinduja at redhat.com
                CC: bugs at gluster.org, csaba at redhat.com,
                    rhs-bugs at redhat.com, storage-qa-internal at redhat.com
        Depends On: 1411607
            Blocks: 1425694



+++ This bug was initially created as a clone of Bug #1411607 +++

Description of problem:
If for some reason MKDIR failed to sync, it will log and proceed further.
Allowing it to further process will fail the entire directory tree syncing to
slave. 


Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Steps to Reproduce:
1. Setup master and slave gluster volume
2. Setup geo-rep session between them
3. Introduce directory sync failure by some means. To manually introduce this
error, delete a directory on slave and Create files and directories under the
deleted directory on master. 

Actual results:
Geo-rep logs the errors and proceeds further

Expected results:
Geo-rep should not proceed if it's a directory error.

Additional info:

--- Additional comment from Worker Ant on 2017-01-10 01:22:34 EST ---

REVIEW: http://review.gluster.org/16364 (geo-rep: Handle directory sync failure
as hard error) posted (#1) for review on master by Kotresh HR
(khiremat at redhat.com)

--- Additional comment from Worker Ant on 2017-01-13 01:55:18 EST ---

REVIEW: http://review.gluster.org/16364 (geo-rep: Handle directory sync failure
as hard error) posted (#2) for review on master by Kotresh HR
(khiremat at redhat.com)

--- Additional comment from Worker Ant on 2017-01-13 08:00:08 EST ---

COMMIT: http://review.gluster.org/16364 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit 91ad7fe0ed8e8ce8f5899bb5ebbbbe57ede7dd43
Author: Kotresh HR <khiremat at redhat.com>
Date:   Tue Jan 10 00:30:42 2017 -0500

    geo-rep: Handle directory sync failure as hard error

    If directory creation is failed, return immediately before
    further processing. Allowing it to further process will
    fail the entire directory tree syncing to slave. Hence
    master will log and raise exception if it's directory
    failure. Earlier, master used to log the failure and
    proceed.

    Change-Id: Iba2a8b5d3d0092e7a9c8a3c2cdf9e6e29c73ddf0
    BUG: 1411607
    Signed-off-by: Kotresh HR <khiremat at redhat.com>
    Reviewed-on: http://review.gluster.org/16364
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Aravinda VK <avishwan at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1411607
[Bug 1411607] [Geo-rep] If for some reason MKDIR failed to sync, it should
not proceed further.
https://bugzilla.redhat.com/show_bug.cgi?id=1425694
[Bug 1425694] [Geo-rep] If for some reason MKDIR failed to sync, it should
not proceed further.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NHqTeqCmLg&a=cc_unsubscribe