[Bugs] [Bug 1425325] New: gluster bash completion leaks TOP= 0 into the environment

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1425325

            Bug ID: 1425325
           Summary: gluster bash completion leaks TOP=0 into the
                    environment
           Product: GlusterFS
           Version: mainline
         Component: cli
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ndevos at redhat.com
                CC: anoopcs at redhat.com, bugs at gluster.org,
                    humble.devassy at gmail.com, joe at julianfamily.org,
                    jonathansteffan at gmail.com, lmohanty at redhat.com,
                    ndevos at redhat.com, ramkrsna at gmail.com,
                    rjones at redhat.com
            Blocks: 1360888



+++ This bug was initially created as a clone of Bug #1360888 +++

Description of problem:

On my machine I have a bash shell variable called "TOP" defined:

$ echo $TOP
0

(Note this is not an environment variable).  This breaks
various things, in this case the lowRISC initialization script.

The variable comes from gluster bash completion script
/etc/bash_completion.d/gluster

Version-Release number of selected component (if applicable):

glusterfs-cli-3.8.0-0.2.rc2.fc24.x86_64

How reproducible:

100%

Steps to Reproduce:
1. echo $TOP

--- Additional comment from Niels de Vos on 2016-09-12 07:37:16 CEST ---

All 3.8.x bugs are now reported against version 3.8 (without .x). For more
information, see
http://www.gluster.org/pipermail/gluster-devel/2016-September/050859.html

--- Additional comment from Anoop C S on 2017-02-21 07:16:52 CET ---

(In reply to Richard W.M. Jones from comment #0)
> Description of problem:
> 
> On my machine I have a bash shell variable called "TOP" defined:
> 
> $ echo $TOP
> 0
> 
> (Note this is not an environment variable).  This breaks
> various things, in this case the lowRISC initialization script.
> 

Can you please direct towards this initialization script?

And how severe is the issue?

> The variable comes from gluster bash completion script
> /etc/bash_completion.d/gluster
> 
> Version-Release number of selected component (if applicable):
> 
> glusterfs-cli-3.8.0-0.2.rc2.fc24.x86_64
> 
> How reproducible:
> 
> 100%
> 
> Steps to Reproduce:
> 1. echo $TOP

--- Additional comment from Richard W.M. Jones on 2017-02-21 09:26:22 CET ---

(In reply to Anoop C S from comment #2)
> Can you please direct towards this initialization script?

As stated in the original description:

  /etc/bash_completion.d/gluster

from the package glusterfs-cli.  In the source, this file is
called extras/command-completion/gluster.bash

> And how severe is the issue?

Annoying more than severe.  However it prevents building all
the RISC-V upstream software.

--- Additional comment from Niels de Vos on 2017-02-21 09:37:39 CET ---

It looks like "TOP" is not the only variable that leaks:

>From <glusterfs.git>/extras/command-completion/gluster.bash:
285 declare FINAL_LIST=''
286 declare LIST=''
287 declare -i TOP=0


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1360888
[Bug 1360888] gluster bash completion leaks TOP=0 into the environment
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.