[Bugs] [Bug 1420810] New: Massive xlator_t leak in graph-switch code

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1420810

            Bug ID: 1420810
           Summary: Massive xlator_t leak in graph-switch code
           Product: GlusterFS
           Version: 3.10
         Component: core
          Assignee: bugs at gluster.org
          Reporter: jdarcy at redhat.com
                CC: bugs at gluster.org
        Depends On: 1420571



+++ This bug was initially created as a clone of Bug #1420571 +++

In high-scale tests (hundreds of volumes with four bricks each) it became
apparent that a frightening percentage of our memory in a brick process was
being consumed by xlator_t structures, in numbers exactly proportional to the
*square* of how many volumes we had.  This happens because every volume
creation would result in a FETCHSPEC request being sent and acted upon for
every previously existing volume.  Since the teardown of the graph used to
process each such request wasn't freeing the xlator_t, this would leak every
xlator_t in every temporary graph on every iteration.

The fix, quite simply, is to take advantage of the painstaking work already
done and *actually free* the structure at the right point.

--- Additional comment from Worker Ant on 2017-02-08 19:56:33 EST ---

REVIEW: https://review.gluster.org/16570 (libglusterfs: fix serious leak of
xlator_t structures) posted (#1) for review on master by Jeff Darcy
(jdarcy at redhat.com)

--- Additional comment from Worker Ant on 2017-02-09 08:49:13 EST ---

COMMIT: https://review.gluster.org/16570 committed in master by Shyamsundar
Ranganathan (srangana at redhat.com) 
------
commit 2199c688b73dfe90868f9469f92e21b0e0795e57
Author: Jeff Darcy <jdarcy at redhat.com>
Date:   Wed Feb 8 19:45:46 2017 -0500

    libglusterfs: fix serious leak of xlator_t structures

    There's a lot of logic (and some long comments) around how to free
    these structures safely, but then we didn't do it.  Now we do.

    Change-Id: I9731ae75c60e99cc43d33d0813a86912db97fd96
    BUG: 1420571
    Signed-off-by: Jeff Darcy <jdarcy at redhat.com>
    Reviewed-on: https://review.gluster.org/16570
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Poornima G <pgurusid at redhat.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1420571
[Bug 1420571] Massive xlator_t leak in graph-switch code
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.