[Bugs] [Bug 1420434] New: Trash feature improperly disabled

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1420434

            Bug ID: 1420434
           Summary: Trash feature improperly disabled
           Product: GlusterFS
           Version: mainline
         Component: trash-xlator
          Assignee: bugs at gluster.org
          Reporter: jdarcy at redhat.com
                CC: bugs at gluster.org



In the course of multiplexing development, it was found that the trash
translator would crash if more than one instance was present in a single brick
process.  Accordingly, trash was disabled so other work could continue.  The
crashes look like this.

#0  0x00007f1740887ee2 in trash_dir_lookup_cbk (frame=0x7f16f017a5d0, 
    cookie=0x7f16f017b190, this=0x7f171c002320, op_ret=-1, op_errno=2, 
    inode=0x0, buf=0x7f1706ffb300, xdata=0x0, postparent=0x7f1706ffb290)
    at trash.c:680
#1  0x00007f17410b68ee in posix_lookup (frame=0x7f16f017b190, 
    this=0x7f171c001020, loc=0x7f1706ffb480, xdata=0x0) at posix.c:257
#2  0x00007f1740888723 in create_or_rename_trash_directory (
    this=0x7f171c002320) at trash.c:750
#3  0x00007f1740897561 in reconfigure (this=0x7f171c002320, 
    options=0x7f16f015e080) at trash.c:2286

The problem is that the order of reconfigure vs. notify(CHILD_UP) is different
with multiplexing, and only the notify path was allocating priv->trash_itable. 
Moving that to the translator's init seems to fix the problem, so trash can be
reenabled.  Patch as soon as I have the bug number.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.