[Bugs] [Bug 1419868] New: removing old tier commands under the rebalance commands

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 7 09:50:40 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1419868

            Bug ID: 1419868
           Summary: removing old tier commands under the rebalance
                    commands
           Product: GlusterFS
           Version: 3.10
         Component: tiering
          Keywords: Triaged
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: hgowtham at redhat.com
        QA Contact: bugs at gluster.org
                CC: amukherj at redhat.com, bugs at gluster.org
        Depends On: 1415590



+++ This bug was initially created as a clone of Bug #1415590 +++

Description of problem:
gluster v rebalance <volname> tier {start|status} spawns a new tier daemon and
shows status for that.
The tier daemon spawned under service framework and the one with rebalance
command are different and we end up with two tier daemons. the older one has to
be removed. 

Version-Release number of selected component (if applicable):
mainline

How reproducible:
100%

Steps to Reproduce:
1.create a volume (any configuration)
2.attach a tier to this volume using the gluster v tier <volname> attach ...
command (spawns a tier daemon)
3.issue gluster v rebalance <volname> tier start (spawns another tier for the
same volume)

Actual results:
creates a new daemon and ends up showing the status for that daemon also.

Expected results:
gluster v rebalance <volname> tier start/status should not create new daemon.
or should connect to the actual tier daemon from service framework.

Additional info:
both the commands can be made to work with one tierd but that will make the new
tierd under service framework ugly and hard to maintain. As the rebalance
commands are being separated from tier commands, its better to remove the
support for the older tier commands under rebalance.

--- Additional comment from Worker Ant on 2017-01-25 02:02:58 EST ---

REVIEW: https://review.gluster.org/16463 (CLI/TIER: removing old tier commands
under rebalance) posted (#2) for review on master by hari gowtham
(hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2017-02-06 02:51:02 EST ---

REVIEW: https://review.gluster.org/16463 (CLI/TIER: removing old tier commands
under rebalance) posted (#3) for review on master by hari gowtham
(hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2017-02-07 01:36:30 EST ---

COMMIT: https://review.gluster.org/16463 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 563cafb5a5e742fc7fd2c175b332f0000c053040
Author: hari gowtham <hgowtham at redhat.com>
Date:   Tue Jan 24 14:24:47 2017 +0530

    CLI/TIER: removing old tier commands under rebalance

    PROBLEM: gluster v rebalance <volname> tier start works even after
    the switch of tier to service framework.
    This lets the user have two tierd for the same volume.

    FIX: checking for each process will make the new code hard
    to maintain. So we are removing the support for old commands.

    Change-Id: I5b0974b2dbb74f0bee8344b61c7f924300ad73f2
    BUG: 1415590
    Signed-off-by: hari gowtham <hgowtham at redhat.com>
    Reviewed-on: https://review.gluster.org/16463
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Tested-by: hari gowtham <hari.gowtham005 at gmail.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1415590
[Bug 1415590] removing old tier commands under the rebalance commands
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list