[Bugs] [Bug 1418650] Samba crash when mounting a distributed dispersed volume over CIFS

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1418650



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16522 committed in release-3.10 by
Shyamsundar Ranganathan (srangana at redhat.com) 
------
commit cc0f3623c037529a3c3f3d1c81f2c8d281d64dba
Author: Xavier Hernandez <xhernandez at datalab.es>
Date:   Fri Jan 13 13:54:35 2017 +0100

    cluster/ec: fix selinux issues with mmap()

    EC uses mmap() to create a memory area for the dynamic code. Since
    the code is created on the fly and executed when needed, this region
    of memory needs to have write and execution privileges.

    This combination is not allowed by default by selinux. To solve the
    problem a file is used as a backend storage for the dynamic code and
    it's mapped into two distinct memory regions, one with write access
    and the other one with execution access. This approach is the
    recommended way to create dynamic code by a program in a more secure
    way, and selinux allows it.

    Additionally selinux requires that the backend file be stored in a
    directory marked with type bin_t to be able to map it in an executable
    area. To satisfy this condition, GLUSTERFS_LIBEXECDIR has been used.

    This fix also changes the error check for mmap(), that was done
    incorrectly (it checked against NULL instead of MAP_FAILED), and it
    also correctly propagates the error codes and makes sure they aren't
    silently ignored.

    > Change-Id: I71c2f88be4e4d795b6cfff96ab3799c362c54291
    > BUG: 1402661
    > Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    > Reviewed-on: https://review.gluster.org/16405
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

    Change-Id: I5c2dd51b1161505316c8f78b73e9a585d0c115d0
    BUG: 1418650
    Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-on: https://review.gluster.org/16522
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lv2TS19wlV&a=cc_unsubscribe