[Bugs] [Bug 1527276] New: feature/bitrot: remove internal xattrs from lookup cbk

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1527276

            Bug ID: 1527276
           Summary: feature/bitrot: remove internal xattrs from lookup cbk
           Product: GlusterFS
           Version: 3.12
         Component: bitrot
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org
        Depends On: 1524365
            Blocks: 1527275
      Docs Contact: bugs at gluster.org



+++ This bug was initially created as a clone of Bug #1524365 +++

Problem:
    afr requests all xattrs in lookup via the list-xattr key. If bitrot is
    enabled and later disabled, or if the bitrot xattrs were present due to
    an older version of bitrot which used to create the xattrs without
    enabling the feature, the xattrs (trusted.bit-rot.version in particular)
    was not getting filtered and ended up reaching the client stack. AFR, on
    noticing different values of the xattr across bricks of the replica,
    started triggering spurious metadata heals.

    Fix:
    Filter all internal xattrs in bitrot xlator before unwinding lookup.

--- Additional comment from Worker Ant on 2017-12-11 05:57:13 EST ---

REVIEW: https://review.gluster.org/19021 (feature/bitrot: remove internal
xattrs from lookup cbk) posted (#1) for review on master by Ravishankar N

--- Additional comment from Worker Ant on 2017-12-18 23:26:29 EST ---

COMMIT: https://review.gluster.org/19021 committed in master by \"Ravishankar
N\" <ravishankar at redhat.com> with a commit message- feature/bitrot: remove
internal xattrs from lookup cbk

Problem:
afr requests all xattrs in lookup via the list-xattr key. If bitrot is
enabled and later disabled, or if the bitrot xattrs were present due to
an older version of bitrot which used to create the xattrs without
enabling the feature, the xattrs (trusted.bit-rot.version in particular)
was not getting filtered and ended up reaching the client stack. AFR, on
noticing different values of the xattr across bricks of the replica,
started triggering spurious metadata heals.

Fix:
Filter all internal xattrs in bitrot xlator before unwinding lookup,
(f)getxattr.

Thanks to Kotresh for the help in RCA'ing.

Change-Id: I5bc70e4b901359c3daefc67b8e4fa6ddb47f046c
BUG: 1524365
Signed-off-by: Ravishankar N <ravishankar at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1524365
[Bug 1524365] feature/bitrot: remove internal xattrs from lookup cbk
https://bugzilla.redhat.com/show_bug.cgi?id=1527275
[Bug 1527275] feature/bitrot: remove internal xattrs from lookup cbk
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are the Docs Contact for the bug.