[Bugs] [Bug 1399593] New: Obvious typo in cleanup code in rpc_clnt_notify

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1399593

            Bug ID: 1399593
           Summary: Obvious typo in cleanup code in rpc_clnt_notify
           Product: GlusterFS
           Version: mainline
         Component: rpc
          Assignee: bugs at gluster.org
          Reporter: mateusz.slupny at appeartv.com
                CC: bugs at gluster.org



Description of problem:

Oddity found when analyzing the code in rpc-clnt.c, funtion rpc_clnt_notify:

(..)
rpc_clnt_ref (clnt);
conn->reconnect =
    gf_timer_call_after (clnt->ctx, ts,
    rpc_clnt_reconnect,
    conn);
if (conn->reconnect == NULL) {
    gf_log (conn->name, GF_LOG_WARNING,
            "Cannot create rpc_clnt_reconnect timer");
    unref_clnt = _gf_true;
}
(..)
if (unref_clnt)
    rpc_clnt_ref (clnt);
(..)

If we weren't able to to create the reconnect timer task, then RPC client's
reference count should be decreased, not increased.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.