[Bugs] [Bug 1369766] glusterd: add brick command should re-use the port for listening which is freed by remove-brick.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1369766



--- Comment #6 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15308 committed in release-3.8 by Niels de
Vos (ndevos at redhat.com) 
------
commit 394c654cd26f232ed493442a5858017be0518b28
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Mon Jul 25 19:09:08 2016 +0530

    glusterd: clean up old port and allocate new one on every restart

        Backport of http://review.gluster.org/#/c/15005/9.

    GlusterD as of now was blindly assuming that the brick port which was
    already allocated would be available to be reused and that assumption
    is absolutely wrong.

    Solution : On first attempt, we thought GlusterD should check if the
    already allocated brick ports are free, if not allocate new port and
    pass it to the daemon. But with that approach there is a possibility
    that if PMAP_SIGNOUT is missed out, the stale port will be given back
    to the clients where connection will keep on failing. Now given the
    port allocation always start from base_port, if everytime a new port
    has to be allocated for the daemons, the port range will still be
    under control. So this fix tries to clean up old port using
    pmap_registry_remove () if any and then goes for pmap_registry_alloc ()

    This patch is being ported to 3.8 branch because, the brick process
    blindly re-using old port, without registering with the pmap server,
    causes snapd daemon to not start properly, even though snapd registers
    with the pmap server. With this patch, all the brick processes and
    snapd will register with the pmap server to either get the same port,
    or a new port, and avoid port collision.

    > Reviewed-on: http://review.gluster.org/15005
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Avra Sengupta <asengupt at redhat.com>

    (cherry picked from commit c3dee6d35326c6495591eb5bbf7f52f64031e2c4)

    Change-Id: If54a055d01ab0cbc06589dc1191d8fc52eb2c84f
    BUG: 1369766
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/15308
    Tested-by: Avra Sengupta <asengupt at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l5QCvjdw5S&a=cc_unsubscribe