[Bugs] [Bug 1392364] New: trashcan max file limit cannot go beyond 1GB

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1392364

            Bug ID: 1392364
           Summary: trashcan max file limit cannot go beyond 1GB
           Product: GlusterFS
           Version: 3.8
         Component: trash-xlator
          Keywords: EasyFix, Triaged
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: anoopcs at redhat.com
                CC: anoopcs at redhat.com, bugs at gluster.org, jackie at drive.ai,
                    jthottan at redhat.com
        Depends On: 1386766
            Blocks: 1392363



+++ This bug was initially created as a clone of Bug #1386766 +++

Description of problem:

max file size supported by trashcan feature is hardcoded to 1GB.  For admins
who manage volumes where only larger files are stored, this heavily erodes the
value of the trashcan feature.  it would be nice to either not have this limit,
or have an override option.


Version-Release number of selected component (if applicable):
all versions with trashcan I believe.  I am using 3.8 myself.

How reproducible:
trivial, it was a feature, not a bug.

Steps to Reproduce:
1. enable trashcan
2. increase limit to something above 1GB
3. delete a large file (larger than 1GB)

Actual results:
large file deleted permanently, bypassing trashcan

Desired (by me at least!) results:
large file goes to trashcan

Additional info:

--- Additional comment from Worker Ant on 2016-10-21 00:13:57 IST ---

REVIEW: http://review.gluster.org/15689 (xlators/trash : Remove upper limit for
trash max file size) posted (#1) for review on master by jiffin tony Thottan
(jthottan at redhat.com)

--- Additional comment from Worker Ant on 2016-11-03 19:39:47 IST ---

COMMIT: http://review.gluster.org/15689 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit cd9be49f6fe05d424989c0686a7e55a3f3ead27e
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Fri Oct 21 00:08:26 2016 +0530

    xlators/trash : Remove upper limit for trash max file size

    Currently file which size exceeds more than 1GB never moved to
    trash directory. This is due to the hard coded check using
    GF_ALLOWED_MAX_FILE_SIZE.

    Change-Id: I2ed707bfe1c3114818896bb27a9856b9a164be92
    BUG: 1386766
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: http://review.gluster.org/15689
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Anoop C S <anoopcs at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1386766
[Bug 1386766] trashcan max file limit cannot go beyond 1GB
https://bugzilla.redhat.com/show_bug.cgi?id=1392363
[Bug 1392363] trashcan max file limit cannot go beyond 1GB
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.