[Bugs] [Bug 1302955] New: Hook scripts are not installed after make install

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1302955

            Bug ID: 1302955
           Summary: Hook scripts are not installed after make install
           Product: GlusterFS
           Version: 3.7.7
         Component: build
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: vmallika at redhat.com
                CC: bugs at gluster.org, kkeithle at redhat.com,
                    lmohanty at redhat.com, ndevos at redhat.com
        Depends On: 1174765
            Blocks: 1171477, 1293708



+++ This bug was initially created as a clone of Bug #1174765 +++

+++ This bug was initially created as a clone of Bug #1171477 +++

Description of problem:
When GLusterFS is built from source, the hook scripts are not copied over to
/var/lib/glusterd/hooks as part of the install make target.

Version-Release number of selected component (if applicable):
3.5.3

How reproducible:
5 times on 5 makes of Gluster on CentOS 6.4

Steps to Reproduce:
1. Download source and build
2. Observe that directories are created in /var/lib/glusterd/hooks, but hook
scripts are not copied over

Actual results:
Hook scripts are not present in hooks directories

Expected results:
Hook scripts should be present in hooks directories after running make install

Additional info:
Attaching directory listings for the hooks directory post-install and in the
source folder.

--- Additional comment from David Gibbons on 2014-12-07 16:24:06 CET ---



--- Additional comment from Niels de Vos on 2014-12-16 13:49:13 CET ---

The hook scripts are manually installed in the glusterfs.spec. It is much
better to install these scripts when "make install" is run. This would make it
much more common user experience on all distributions and manual installations.

--- Additional comment from Vijay Bellur on 2015-12-23 08:05:00 EST ---

REVIEW: http://review.gluster.org/13072 (build: use 'make install' to install
the hook scripts) posted (#1) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-26 12:31:39 EST ---

COMMIT: http://review.gluster.org/13072 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 7ab8a1a3f4510a284b1686302624ec4252c95a6f
Author: Niels de Vos <ndevos at redhat.com>
Date:   Wed Dec 23 13:57:14 2015 +0100

    build: use 'make install' to install the hook scripts

    The installation should be the same on all distributions, and doing
    manual installation of files in the .spec is very ugly. This change adds
    the rules so that 'make install' places the hook scripts in the right
    location.

    Also, the hook script(s) for NFS-Ganesha should be part of the
    glusterfs-ganesha sub-package and got moved there.

    BUG: 1174765
    Change-Id: Iba25a7a5112c7d40db4c10ff4a5ac7a5fb4f7c4e
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/13072
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

--- Additional comment from Kaleb KEITHLEY on 2015-12-28 07:23:56 EST ---



--- Additional comment from Kaleb KEITHLEY on 2015-12-28 07:25:22 EST ---


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1171477
[Bug 1171477] Hook scripts are not installed after make install
https://bugzilla.redhat.com/show_bug.cgi?id=1174765
[Bug 1174765] Hook scripts are not installed after make install
https://bugzilla.redhat.com/show_bug.cgi?id=1293708
[Bug 1293708] hooks: Ganesha and Samba hooks are always installed
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.