[Bugs] [Bug 1300210] New: Fix sparse-file-self-heal.t and remove from bad tests

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 20 09:30:46 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1300210

            Bug ID: 1300210
           Summary: Fix sparse-file-self-heal.t and remove from bad tests
           Product: GlusterFS
           Version: 3.7.7
         Component: tests
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org
        Depends On: 1298111



+++ This bug was initially created as a clone of Bug #1298111 +++

Description of problem:

Psuedo Problem:
   
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16682/consoleFull

    The 'zeroedfile' disk usage comparision which is failing in this .t file
    fails so only on XFS. The test passes when the backend is on a s̶a̶n̶e̶r̶
    different filesystem like EXT4 or BTRFS. This is due to the speculative
    preallocation in XFS which can reserve different disk space on different
    XFS mounts for the same version and same file operation. See BZ 1277992
    for an example of XFS behaviour.

    Fix:
    Don't compare the disk usage of the file on the bricks of the replica:
    instead, check that the disk space consumed is atleast equal to the size
    of the file.

    Also remove sparse-file-self-heal.t from is_bad_test()

--- Additional comment from Vijay Bellur on 2016-01-13 04:44:48 EST ---

REVIEW: http://review.gluster.org/13233 (tests: Fix sparse-file-self-heal.t)
posted (#1) for review on master by Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2016-01-13 08:04:59 EST ---

REVIEW: http://review.gluster.org/13233 (tests: Fix sparse-file-self-heal.t)
posted (#2) for review on master by Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2016-01-20 04:22:57 EST ---

COMMIT: http://review.gluster.org/13233 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 6d430b85a39784f96b69368e1a9c8b4be4d0ddb1
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Wed Jan 13 14:37:30 2016 +0530

    tests: Fix sparse-file-self-heal.t

    Psuedo Problem:
   
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16682/consoleFull

    The 'zeroedfile' disk usage comparision which is failing in this .t file
    fails so only on XFS. The test passes when the backend is on a s̶a̶n̶e̶r̶
    different filesystem like EXT4 or BTRFS. This is due to the speculative
    preallocation in XFS which can reserve different disk space on different
    XFS mounts for the same version and same file operation. See BZ 1277992
    for an example of XFS behaviour.

    Fix:
    Don't compare the disk usage of the file on the bricks of the replica:
    instead, check that the disk space consumed is atleast equal to the size
    of the file.

    Also remove sparse-file-self-heal.t from is_bad_test()

    Change-Id: If43f59549136ebf91f17ff9d958954b3587afe56
    BUG: 1298111
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/13233
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1298111
[Bug 1298111] Fix sparse-file-self-heal.t and remove from bad tests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list