[Bugs] [Bug 1299724] New: Excessive logging in mount when bricks of the replica are down

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1299724

            Bug ID: 1299724
           Summary: Excessive logging in mount when bricks of the replica
                    are down
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: gluster-afr
          Keywords: Triaged, ZStream
          Severity: high
          Assignee: pkarampu at redhat.com
          Reporter: spandura at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: bugs at gluster.org, ravishankar at redhat.com
        Depends On: 1294053
          Keywords: ZStream



+++ This bug was initially created as a clone of Bug #1294053 +++

Description of problem:

Commit 2b7226f9d3470d8fe4c98c1fddb06e7f641e364d did not check for the
validity of a dict before doing a dict_get. This floods the mount log with lot
of spurios messages when one of the bricks is down in a replica subovolume:

[2015-12-24 09:31:48.793530] I [dict.c:462:dict_get]
(-->/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(+0x4de19)
[0x7fabffdd6e19]
-->/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(+0x4d946)
[0x7fabffdd6946] -->/usr/local/lib/libglusterfs.so.0(dict_get+0x72)
[0x7fac11800302] ) 0-dict: !this || key=glusterfs.bad-inode [Invalid argument]
[2015-12-24 09:31:48.794164] I [dict.c:462:dict_get]
(-->/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(+0x4de19)
[0x7fabffdd6e19]
-->/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(+0x4d946)
[0x7fabffdd6946] -->/usr/local/lib/libglusterfs.so.0(dict_get+0x72)
[0x7fac11800302] ) 0-dict: !this || key=glusterfs.bad-inode [Invalid argument]
[2015-12-24 09:31:48.794692] I [dict.c:462:dict_get]
(-->/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(+0x4de19)
[0x7fabffdd6e19]

--- Additional comment from Vijay Bellur on 2015-12-24 05:12:23 EST ---

REVIEW: http://review.gluster.org/13077 (afr: Fix excessive logging in
afr_accuse_smallfiles()) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-28 06:55:47 EST ---

REVIEW: http://review.gluster.org/13077 (afr: Fix excessive logging in
afr_accuse_smallfiles()) posted (#2) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-29 02:26:33 EST ---

COMMIT: http://review.gluster.org/13077 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 4c1b66720121ca97ccfac3e09f93519f2f07ddfd
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Thu Dec 24 15:22:05 2015 +0530

    afr: Fix excessive logging in afr_accuse_smallfiles()

    Commit 2b7226f9d3470d8fe4c98c1fddb06e7f641e364d did not check for the
    validity of a dict before doing a dict_get. Fix that.

    Change-Id: Ie21f4da19256b17196f242cd8fd5bb76b0a69c1e
    BUG: 1294053
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/13077
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

--- Additional comment from Ravishankar N on 2016-01-06 08:32:31 EST ---

Found one more code path where the message gets logged, hence moving the bug
back to post and using the same bug ID for the next patch.

--- Additional comment from Vijay Bellur on 2016-01-06 08:37:05 EST ---

REVIEW: http://review.gluster.org/13185 (afr : Check if dict is valid in
afr_replies_interpret()) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2016-01-10 23:32:27 EST ---

REVIEW: http://review.gluster.org/13185 (afr : Check if dict is valid in
afr_replies_interpret()) posted (#2) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2016-01-12 05:42:54 EST ---

REVIEW: http://review.gluster.org/13185 (afr : Check if dict is valid in
afr_replies_interpret()) posted (#3) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2016-01-18 02:12:01 EST ---

REVIEW: http://review.gluster.org/13185 (afr : Check if dict is valid in
afr_replies_interpret()) posted (#4) for review on master by Ravishankar N
(ravishankar at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1294053
[Bug 1294053] Excessive logging in mount when bricks of the replica are
down
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YxGLqumHae&a=cc_unsubscribe