[Bugs] [Bug 1295784] dht: misleading indentation, gcc-6

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1295784



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13176 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit a2119ef0f18d51500f5b496caf8dfd8f192dd490
Author: Kaleb S KEITHLEY <kkeithle at redhat.com>
Date:   Tue Jan 5 07:52:25 2016 -0500

    dht: missleading indendentation, gcc-6

    gcc-6 now has -Wmisleading-indentation as part of -Wall.

    compiling with gcc-6 gives this warning.

    ...
    dht-diskusage.c: In function ‘dht_subvol_has_err’:
    dht-diskusage.c:361:33: warning: statement is indented as if it were
    guarded by... [-Wmisleading-indentation]
                                     goto out;
                                     ^~~~

    dht-diskusage.c:358:25: note: ...this ‘if’ clause, but it is not
                             if (conf->decommissioned_bricks[i] &&
                             ^~
    ...

    Inspection of the source shows that without braces the loop is
    terminated prematurely.

    Change-Id: Ica48a8c59ee5d0a206797827d7920259d33b47ec
    BUG: 1295784
    Signed-off-by: Kaleb S KEITHLEY <kkeithle at redhat.com>
    Reviewed-on: http://review.gluster.org/13176
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MJqhlwdtKE&a=cc_unsubscribe