[Bugs] [Bug 1331933] New: rm -rf to a dir gives directory not empty(ENOTEMPTY) error

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1331933

            Bug ID: 1331933
           Summary: rm -rf to a dir gives directory not empty(ENOTEMPTY)
                    error
           Product: GlusterFS
           Version: 3.7.11
         Component: distribute
          Severity: high
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: rgowdapp at redhat.com
                CC: bkunal at redhat.com, bugs at gluster.org,
                    nbalacha at redhat.com, storage-qa-internal at redhat.com
        Depends On: 1329514, 1330032



+++ This bug was initially created as a clone of Bug #1330032 +++

+++ This bug was initially created as a clone of Bug #1329514 +++

Description of problem:
2x2 distributed replicate volume.

1) Customer were using fuse client. When they were deleting a directory (which
looked empty when "ls" was done on the mount point) they were getting ENOTEMPTY
errors.

2) Installed glusterfs-debuginfo package, and then attached to the glusterfs
client process via gdb.

3) When gdb was attached and breakpoints were put, found that the directory
being removed was not empty on all the nodes. 

The directory being removed (name "Dir45") was empty on one distribute
subvolumes. The other subvolume had an empty sub directory inside it (the name
of the subdirectory is "bucket7").

"ls" of Dir45 was not showing bucket7 to be present. But backend had that
subdirectory. When ls on the subdirectory was explicitly done, then it was
healed by distribute and "ls" on its parent directory (i.e. Dir45) started
showing that entry.

Version-Release number of selected component (if applicable):
3.1.1

--- Additional comment from Nithya Balachandran on 2016-04-25 06:31:34 EDT ---

Steps to reproduce the issue:

1. Create a 2x2 dist-rep volume.
2. Set cluster.quorum-type to auto.
3. NFS mount the volume
4. mkdir -p dir1/dir2/dir3/dir4
5. Kill the first brick process for the non-hashed subvol for dir4
6. Try to delete dir4 : rmdir dir1/dir2/dir3/dir4

Expected results:
rmdir fails with EROFS. The directory should exist on all the bricks.

Actual results:
rmdir fails with EROFS but the directory is deleted from the hashed subvol.




RCA:


In dht_rmdir_cbk:
                if (op_ret == -1) {
                        if ((op_errno != ENOENT) && (op_errno != ESTALE)) {
                                local->op_errno = op_errno;
                                local->op_ret = -1;

                                if (op_errno != EACCES)
                                        local->need_selfheal = 1;  <--
local->need_selfheal is set to 1 as op_errno is EROFS.
                        }

                        gf_uuid_unparse(local->loc.gfid, gfid);

                        gf_msg_debug (this->name, op_errno,
                                      "rmdir on %s for %s failed."
                                      "(gfid = %s)",
                                      prev->this->name, local->loc.path,
                                      gfid);
                        goto unlock;
                }


However, local->fop_succeeded is still 0 as there are only 2 subvols.


                } else if (this_call_cnt) {
                        /* If non-hashed subvol's have responded, proceed */

---> No check is performed here to see if the fop succeeded. rmdir is wound to
the hashed subvol and succeeds.

                        local->need_selfheal = 0;
                        STACK_WIND (frame, dht_rmdir_hashed_subvol_cbk,
                                    local->hashed_subvol,
                                    local->hashed_subvol->fops->rmdir,
                                    &local->loc, local->flags, NULL);
                } else if (!this_call_cnt) {


Now dir4 exists on the non-hashed subvol but not the hashed subvol.
ls dir1/dir2/dir3 shows no entries but rmdir dir1/dir2/dir3 returns ENOTEMPTY.

--- Additional comment from Vijay Bellur on 2016-04-25 06:39:46 EDT ---

REVIEW: http://review.gluster.org/14060 (cluster/dht: Handle rmdir failure
correctly) posted (#1) for review on master by N Balachandran
(nbalacha at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-27 12:59:50 EDT ---

REVIEW: http://review.gluster.org/14060 (cluster/dht: Handle rmdir failure
correctly) posted (#2) for review on master by N Balachandran
(nbalacha at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-28 06:05:02 EDT ---

REVIEW: http://review.gluster.org/14060 (cluster/dht: Handle rmdir failure
correctly) posted (#3) for review on master by N Balachandran
(nbalacha at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329514
[Bug 1329514] rm -rf to a dir gives directory not empty(ENOTEMPTY) error
https://bugzilla.redhat.com/show_bug.cgi?id=1330032
[Bug 1330032] rm -rf to a dir gives directory not empty(ENOTEMPTY) error
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.