[Bugs] [Bug 1328502] Move FOP enumerations and other network protocol bits to XDR generated headers

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 28 20:51:15 UTC 2016


--- Comment #24 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14032 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
commit 2f945b86d30eca3a32f5e8e42fbe692ddf4b55be
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon Apr 18 21:47:18 2016 +0200

    rpc: split FOPs enum from glusterfs.h

    Moving the enumeration of FOPs and some of the other parts that are
    defining the network protocol to the rpc/xdr/ section. These structures
    need some care when modifications are made, moving them out of the
    common glusterfs.h header helps with that.

    The protocol definition structures are generated in a new glusterfs-fops
    header. This file is present in rpc/xdr/src/ and libglusterfs/src/, it
    is a little ugly, but prevents the need to update all Makefile.am files
    with the additional -I option for finding the new header file.

    The generation of the .c and .h files from the .x descriptions needed
    small modifications to accommodate these changes. The build/xdrgen
    script was improved slightly for this. The .c and .h files are
    incorrectly in the $(top_srcdir), instead of $(top_builddir). This is
    an existing issue, and bug 1330604 has been filed to get that addressed.

    Change-Id: I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9
    BUG: 1328502
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/14032
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fi2PlbLaJR&a=cc_unsubscribe

More information about the Bugs mailing list