[Bugs] [Bug 1198849] Minor improvements and cleanup for the build system

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 28 14:11:41 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1198849



--- Comment #76 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14093 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit fbb655d90aae42398c51469919dde20138e89d7d
Author: Niels de Vos <ndevos at redhat.com>
Date:   Wed Apr 27 14:50:58 2016 +0200

    build: remove unneeded include <sys/user.h> for FreeBSD

    The include <sys/user.h> causes a conflicting definition of an RPC
    'struct pmap':

        --- fuse-helpers.lo ---
        In file included from /usr/include/rpc/rpc.h:73:0,
                         from ../../../../libglusterfs/src/glusterfs-fops.h:35,
                         from
/usr/home/jenkins/root/workspace/freebsd-smoke/libglusterfs/src/glusterfs.h:32,
                         from
/usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-bridge.h:22,
                         from
/usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-helpers.c:26:
        /usr/include/rpc/pmap_prot.h:89:8: error: redefinition of 'struct pmap'
         struct pmap {
                ^
        In file included from /usr/include/vm/pmap.h:90:0,
                         from /usr/include/sys/user.h:52,
                         from
/usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-helpers.c:19:
        /usr/include/machine/pmap.h:299:8: note: originally defined here
         struct pmap {
                ^

    It seems that building on FreeBSD still functions without any additional
    warnings or errors, even when the include is removed.

    Change-id I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9 identified this
    issue, and this build-fix is needed for applying I98fc8cf7.

    BUG: 1198849
    Change-Id: Ib8241b7dc47eb2c3593d2f8ea1d196178e63d02d
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/14093
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5KThiVotwL&a=cc_unsubscribe


More information about the Bugs mailing list