[Bugs] [Bug 1328502] Move FOP enumerations and other network protocol bits to XDR generated headers

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 27 09:11:59 UTC 2016


--- Comment #20 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14035 committed in master by Niels de Vos
(ndevos at redhat.com) 
commit 60cf56b1289bbf574a38a7f99f8cacb692f65474
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon Apr 18 19:34:26 2016 +0200

    snapshot: svc_stat collides with define from /usr/include/rpc/svc.h

    Compiling fails with this error:

        snapview-client.c:559:24: error: macro "svc_stat" passed 4 arguments,
but takes just 1
                   dict_t *xdata)
        snapview-client.c:560:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
‘__attribute__’ before ‘{’ token
        snapview-client.c:2412:26: error: ‘svc_stat’ undeclared here (not in a
                 .stat          = svc_stat,

    svc_* is the common prefix for (SUN)RPC functions provided by system
    headers. svc_stat() seems to be an existing function name. This happens
    because change-id I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9 causes
    <rpc/rpc.h> included through "glusterfs.h". Prepending gf_ for all svc_*
    functions works around the symbol collision.

    Change-Id: Idc86b719c48675a5154c54d844c1899d14d46e2a
    BUG: 1328502
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/14035
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i2nh3KgVW1&a=cc_unsubscribe

More information about the Bugs mailing list