[Bugs] [Bug 1329870] Lots of [global.glusterfs - usage-type (null) memusage] are seen in statedump

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1329870



--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14054 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit 3c04a91f5245708d0a148bf01cfdac1d0d59c797
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Sun Apr 24 06:31:14 2016 +0530

    statedump: Prevent (null) typestr to be printed

    Problem:
    After the commits: 7e44c783ad731856956929f6614bbe045c26ea3a - lock: use
    spinlock only on multicore systems
    a6aecae2cd8171b8538bfe5d2800bdd157380b85 - nfs: fix lock variable type

    we see a lot of "[global.glusterfs - usage-type (null) memusage]" in
statedump
    because lock status is not all-zeros after init, and the memcmp to check
that
    a datatype is never allocated is invalid.

    Fix:
    Changed if a datatype is allocated or not check based on total_allocs. Also
    removed setting typestr to NULL on gf_free even when num_allocs is 0.
Because
    even that is leading to 'null' memusage string to be printed in statedump.

    BUG: 1329870
    Change-Id: If2b01a557cbdc787625db32e276e06cee3ac46ee
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/14054
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oJJGOG1mfi&a=cc_unsubscribe