[Bugs] [Bug 1327863] New: cluster/afr: Fix partial heals in 3-way replication

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1327863

            Bug ID: 1327863
           Summary: cluster/afr: Fix partial heals in 3-way replication
           Product: GlusterFS
           Version: 3.7.11
         Component: replicate
          Assignee: pkarampu at redhat.com
          Reporter: pkarampu at redhat.com
                CC: bugs at gluster.org
        Depends On: 1318751



+++ This bug was initially created as a clone of Bug #1318751 +++

Description of problem:
    When there are 2 sources and one sink and if two self-heal daemons
    try to acquire locks at the same time, there is a chance that it
    gets a lock on one source and sink leading partial to heal. This will
    need one more heal from the remaining source to sink for the complete
    self-heal. This is not optimal.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-03-17 12:57:55 EDT ---

REVIEW: http://review.gluster.org/13766 (cluster/afr: Fix partial heals in
3-way replication) posted (#1) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-12 12:06:17 EDT ---

REVIEW: http://review.gluster.org/13766 (cluster/afr: Fix partial heals in
3-way replication) posted (#2) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-15 05:51:10 EDT ---

COMMIT: http://review.gluster.org/13766 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 8deedef565df49def75083678f8d1558c7b1f7d3
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Thu Mar 17 19:42:00 2016 +0530

    cluster/afr: Fix partial heals in 3-way replication

    Problem:
    When there are 2 sources and one sink and if two self-heal daemons
    try to acquire locks at the same time, there is a chance that it
    gets a lock on one source and sink leading partial to heal. This will
    need one more heal from the remaining source to sink for the complete
    self-heal. This is not optimal.

    Fix:
    Upgrade non-blocking locks to blocking lock on all the subvolumes, if
    the number of locks acquired is majority and there were eagains.

    BUG: 1318751
    Change-Id: Iae10b8d3402756c4164b98cc49876056ff7a61e5
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/13766
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1318751
[Bug 1318751] cluster/afr: Fix partial heals in 3-way replication
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xg9G1x6pjG&a=cc_unsubscribe