[Bugs] [Bug 1286058] New: Brick crashes because of race in bit-rot init

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1286058

            Bug ID: 1286058
           Summary: Brick crashes because of race in bit-rot init
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: glusterfs
     Sub Component: bitrot
          Assignee: rhs-bugs at redhat.com
          Reporter: knarra at redhat.com
        QA Contact: rmekala at redhat.com
                CC: bugs at gluster.org, pkarampu at redhat.com
        Depends On: 1285616
            Blocks: 1285758



+++ This bug was initially created as a clone of Bug #1285616 +++

Description of problem:
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007fce642eb420 in pthread_mutex_lock () from ./lib64/libpthread.so.0
(gdb) bt
#0  0x00007fce642eb420 in pthread_mutex_lock () from ./lib64/libpthread.so.0
#1  0x00007fce52ee2e13 in br_stub_worker (data=0x7fce54010f90)
    at
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/features/bit-rot/src/stub/bit-rot-stub-helpers.c:337
#2  0x00007fce642e9a51 in start_thread () from ./lib64/libpthread.so.0
#3  0x00007fce63c5393d in clone () from ./lib64/libc.so.6
(gdb) fr 1
#1  0x00007fce52ee2e13 in br_stub_worker (data=0x7fce54010f90)
    at
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/features/bit-rot/src/stub/bit-rot-stub-helpers.c:337
337   
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/features/bit-rot/src/stub/bit-rot-stub-helpers.c:
No such file or directory.
(gdb) info locals
priv = 0x0
this = 0x7fce54010f90
stub = 0x0
ret = 0

init may not have initialized this->private by the time br_stub_worker starts
running, leading to NULL dereference.
Version-Release number of selected component (if applicable):

How reproducible:
This is observed at
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16180/consoleFull

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2015-11-25 23:36:24 EST ---

REVIEW: http://review.gluster.org/12754 (features/bit-rot: Fix NULL
dereference) posted (#1) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2015-11-26 04:03:33 EST ---

REVIEW: http://review.gluster.org/12754 (features/bit-rot: Fix NULL
dereference) posted (#2) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2015-11-26 23:04:23 EST ---

COMMIT: http://review.gluster.org/12754 committed in master by Venky Shankar
(vshankar at redhat.com) 
------
commit a1919e91279a6c691fbd3dd6c0d97e74e78ccf22
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Thu Nov 26 09:58:39 2015 +0530

    features/bit-rot: Fix NULL dereference

    Problem:
    By the time br_stub_worker is accessing this->private in it's
    thread, 'init' may not have set 'this->private = priv'. This
    leads to NULL dereference leading to brick crash.

    Fix:
    Set this->private before launching these threads.

    Change-Id: Ic797eb195fdd0c70d19f28d0b97bc0181fd3dd2f
    BUG: 1285616
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/12754
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Venky Shankar <vshankar at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1285616
[Bug 1285616] Brick crashes because of race in bit-rot init
https://bugzilla.redhat.com/show_bug.cgi?id=1285758
[Bug 1285758] Brick crashes because of race in bit-rot init
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OZ16MK1DuC&a=cc_unsubscribe