[Bugs] [Bug 1285139] New: Sharding - Extending writes filling incorrect final size in postbuf

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1285139

            Bug ID: 1285139
           Summary: Sharding - Extending writes filling incorrect final
                    size in postbuf
           Product: GlusterFS
           Version: 3.7.6
         Component: sharding
          Keywords: Triaged
          Severity: high
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: kdhananj at redhat.com
        QA Contact: bugs at gluster.org
                CC: bugs at gluster.org
        Depends On: 1284365



+++ This bug was initially created as a clone of Bug #1284365 +++

Description of problem:
After an extending write is complete, at the level of shard translator, the
postbuf is updated not once but twice with the same delta size and block count:
once in shard_update_file_size_cbk(), and
once in shard_post_update_size_writev_handler()

This can lead to unexpected behavior is md-cache is part of the client stack
and caches these values returned by shard translator in postbuf.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2015-11-23 02:42:36 EST ---

REVIEW: http://review.gluster.org/12717 (features/shard: Eliminate extra update
to postbuf in writev) posted (#1) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2015-11-23 07:38:35 EST ---

REVIEW: http://review.gluster.org/12717 (features/shard: Eliminate extra update
to postbuf in writev) posted (#2) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2015-11-23 13:58:10 EST ---

REVIEW: http://review.gluster.org/12717 (features/shard: Eliminate extra update
to postbuf in writev) posted (#3) for review on master by Vijay Bellur
(vbellur at redhat.com)

--- Additional comment from Vijay Bellur on 2015-11-24 01:20:06 EST ---

COMMIT: http://review.gluster.org/12717 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit c93e436527e9d2ceed46b939e18edc40b7018cee
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Mon Nov 23 13:06:25 2015 +0530

    features/shard: Eliminate extra update to postbuf in writev

    After an extending write is complete, shard translator updates postbuf
    at two places:
    1. shard_update_file_size_cbk(), and
    2. shard_post_update_size_writev_handler().

    This can lead to unexpected behavior if md-cache is part of the client
    stack and caches and serves values returned by shard translator in
    postbuf. This patch eliminates the update to postbuf in
    shard_post_update_size_writev_handler().

    Change-Id: I9d107bf57baad66886eebec14aa369b6a3c88c49
    BUG: 1284365
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/12717
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1284365
[Bug 1284365] Sharding - Extending writes filling incorrect final size in
postbuf
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.