[Bugs] [Bug 1271310] RFE : Feature: Tunable FOP sampling for v3.6.x/v3.7.x

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 1 17:14:38 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1271310



--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/12210 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit d3e496cbcd35b9d9b840e328ae109c44f59083ce
Author: Richard Wareing <rwareing at fb.com>
Date:   Tue Jun 23 17:03:11 2015 -0700

    debug/io-stats: Add FOP sampling feature

    Summary:
    - Using sampling feature you can record details about every Nth FOP.
      The fields in each sample are: FOP type, hostname, uid, gid, FOP
priority,
      port and time taken (latency) to fufill the request.
    - Implemented using a ring buffer which is not (m/c) allocated in the IO
path,
      this should make the sampling process pretty cheap.
    - DNS resolution done @ dump time not @ sample time for performance w/
      cache
    - Metrics can be used for both diagnostics, traffic/IO profiling as well
      as P95/P99 calculations
    - To control this feature there are two new volume options:
      diagnostics.fop-sample-interval - The sampling interval, e.g. 1 means
      sample every FOP, 100 means sample every 100th FOP
      diagnostics.fop-sample-buf-size - The size (in bytes) of the ring
      buffer used to store the samples.  In the even more samples
      are collected in the stats dump interval than can be held in this buffer,
      the oldest samples shall be discarded.  Samples are stored in the log
      directory under /var/log/glusterfs/samples.
    - Uses DNS cache written by sshreyas at fb.com (Thank-you!), the DNS cache
      TTL is controlled by the diagnostics.stats-dnscache-ttl-sec option
      and defaults to 24hrs.

    Test Plan:
    - Valgrind'd to ensure it's leak free
    - Run prove test(s)
    - Shadow testing on 100+ brick cluster

    Change-Id: I9ee14c2fa18486b7efb38e59f70687249d3f96d8
    BUG: 1271310
    Signed-off-by: Jeff Darcy <jdarcy at redhat.com>
    Reviewed-on: http://review.gluster.org/12210
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list