[Bugs] [Bug 1226157] New: Quota: spurious failures with quota testcases

Fri May 29 06:02:53 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1226157

            Bug ID: 1226157
           Summary: Quota: spurious failures with quota testcases
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: gluster-quota
          Assignee: vagarwal at redhat.com
          Reporter: vmallika at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1223798
            Blocks: 1186580 (qe_tracker_everglades), 1219955
                    (glusterfs-3.7.1), 1224894

+++ This bug was initially created as a clone of Bug #1223798 +++

Some of the below test cases spuriously failing.
./tests/bugs/distribute/bug-1161156.t
./tests/bugs/quota/bug-1038598.t

Problem is quota enforcer doesn't consider parallel writes and fail to send
EDQUOT and allow to exceed quota with few %.

For now, with this patch we fix the testcases not to send parallel writes.
Bug# 1223658 tracks the parallel write issue with quota.

--- Additional comment from Anand Avati on 2015-05-21 09:13:26 EDT ---

REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send
parallel writes for accurate quota enforcement) posted (#1) for review on
master by Vijaikumar Mallikarjuna (vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-21 22:20:14 EDT ---

REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send
parallel writes for accurate quota enforcement) posted (#2) for review on
master by Vijaikumar Mallikarjuna (vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-25 04:09:00 EDT ---

REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send
parallel writes for accurate quota enforcement) posted (#3) for review on
master by Vijaikumar Mallikarjuna (vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-25 04:16:42 EDT ---

REVIEW: http://review.gluster.org/10878 (Quota: fix testcases not to send
parallel writes for accurate quota enforcement) posted (#4) for review on
master by Vijaikumar Mallikarjuna (vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-25 14:34:28 EDT ---

COMMIT: http://review.gluster.org/10878 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 225ff553106396066d68d8c757e5c001f5d9ab15
Author: vmallika <vmallika at redhat.com>
Date:   Mon May 25 13:35:48 2015 +0530

    Quota: fix testcases not to send parallel writes for accurate
    quota enforcement

    Currently quota enforcer doesn't consider parallel writes
    and allows quota to exceed limit where there are high rate
    of parallel writes. Bug# 1223658 tracks the issue.

    This patch fixes the spurious failures by not sending
    parallel writes.
    Using O_SYNC and O_APPEND flags and block size
    not more that 256k (For higher block size NFS client
    splits the block into 256k chinks and does parallel writes)

    Change-Id: I297c164b030cecb87ce5b494c02b09e8b073b276
    BUG: 1223798
    Signed-off-by: vmallika <vmallika at redhat.com>
    Reviewed-on: http://review.gluster.org/10878
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    Tested-by: Raghavendra G <rgowdapp at redhat.com>

--- Additional comment from Anand Avati on 2015-05-26 06:21:00 EDT ---

REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure)
posted (#1) for review on master by Vijaikumar Mallikarjuna
(vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-27 02:47:52 EDT ---

REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure)
posted (#2) for review on master by Vijaikumar Mallikarjuna
(vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-27 06:35:40 EDT ---

REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure)
posted (#4) for review on master by Vijaikumar Mallikarjuna
(vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-27 07:01:26 EDT ---

REVIEW: http://review.gluster.org/10918 (quota: fix for spurious failure)
posted (#5) for review on master by Vijaikumar Mallikarjuna
(vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-05-27 12:09:48 EDT ---

COMMIT: http://review.gluster.org/10918 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit f7bc35358c27d6260d5d1c4e22f1708d7ab60a98
Author: vmallika <vmallika at redhat.com>
Date:   Wed May 27 16:25:27 2015 +0530

    quota: fix for spurious failure

    During ancestry build, loc path was set to invalid
    path. path was set to one of its child instead
    of itself. Because of this quota accounting was
    going wrong

    This patch fix the issue

    Below mentioned tests removed from bad test list
    as part of patch# 10930
            ./tests/basic/ec/quota.t
            ./tests/basic/quota-nfs.t
            ./tests/bugs/quota/bug-1035576.t

    Change-Id: Iaa65b2d968c04c9abcd476d0e9f588cb7fd39294
    BUG: 1223798
    Signed-off-by: vmallika <vmallika at redhat.com>
    Reviewed-on: http://review.gluster.org/10918
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1186580
[Bug 1186580] QE tracker bug for Everglades
https://bugzilla.redhat.com/show_bug.cgi?id=1219955
[Bug 1219955] GlusterFS 3.7.1 tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1223798
[Bug 1223798] Quota: spurious failures with quota testcases
https://bugzilla.redhat.com/show_bug.cgi?id=1224894
[Bug 1224894] Quota: spurious failures with quota testcases
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bNdZA7kXE7&a=cc_unsubscribe