[Bugs] [Bug 789278] Issues reported by Coverity static analysis tool

bugzilla at redhat.com bugzilla at redhat.com
Thu May 28 09:04:09 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=789278



--- Comment #707 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/10782 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit ae9604bbdb4f87ee3f6f11adc3ce6cd140620055
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Thu May 14 14:37:25 2015 +0530

    gfapi: zero size issue in glfs_h_acl_set()

    When setting the stringified ACLs in the xattr dict through
    pub_glfs_h_setxattrs(), the size of the string is always passed as 0.
    The correct way is to pass the length of the ACL in text form.

    While verifying this issues, it seems that posix_pacl_set() should
    return the errno instead of -1. This helps in debugging, otherwise EPERM
    would always be returned on an error.

    [ndevos: fix off-by-one strlen() and return errno in posix_pacl_set()]
    Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
    BUG: 789278
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/10782
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Bugs mailing list