[Bugs] [Bug 1225743] New: [AFR-V2] - afr_final_errno() should treat op_ret > 0 also as success

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1225743

            Bug ID: 1225743
           Summary: [AFR-V2] - afr_final_errno() should treat op_ret > 0
                    also as success
           Product: GlusterFS
           Version: 3.7.0
         Component: replicate
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: kdhananj at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1225491



+++ This bug was initially created as a clone of Bug #1225491 +++

Description of problem:

Figured while reading code that the function afr_final_errno() does not treat
op_ret > 0 as success.

What that means is that in inode write fops (where this function gets called by
__afr_inode_write_finalize()), op_ret could be > 0 on success. And if the inode
write fop failed on one or more subvols, there is a remote possibility that
AFR, instead of choosing the most severe errno from the set of errnos returned
by the subvolumes that saw a failure, winds up picking junk errno from the
subvol where the fop actually succeeded. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-05-27 09:35:46 EDT ---

REVIEW: http://review.gluster.org/10946 (cluster/afr: Treat op_ret >= 0 as
success in afr_final_errno()) posted (#1) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Anand Avati on 2015-05-28 01:36:28 EDT ---

COMMIT: http://review.gluster.org/10946 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 9e1bb640983f72858aeabd793bbb7fc8b5c71b09
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Wed May 27 19:03:12 2015 +0530

    cluster/afr: Treat op_ret >= 0 as success in afr_final_errno()

    Change-Id: I7ec29428b7f7ef249014f948a5d616bfb8aaf80d
    BUG: 1225491
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/10946
    Tested-by: NetBSD Build System
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1225491
[Bug 1225491] [AFR-V2] - afr_final_errno() should treat op_ret > 0 also as
success
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.