[Bugs] [Bug 1224292] peers connected in the middle of a transaction are participating in the transaction

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1224292



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/10937 committed in release-3.7 by Vijay
Bellur (vbellur at redhat.com) 
------
commit 0bcd638b46a7134f0285b39aabfed9950645bdc3
Author: Avra Sengupta <asengupt at redhat.com>
Date:   Fri May 22 18:38:23 2015 +0530

    glusterd: Fix conf->generation to stop new peers participating in
    a transaction, while the transaction is in progress.

            Backport of http://review.gluster.org/#/c/10895/

    Every peer gets a generation number, during it's inception.
    This generation number is used to identify the peer throiughout
    it's lifetime. This number is assigned based on the current
    generation number of the system, which is incremented with every
    peer that is added.

    The problem arises when we add a peer, and before it gets a rpc_connect
    we begin a transaction. In such a case, the peer gets considered in the
    transaction, but doesn't participate in it coz it isn't connected yet.
    The moment it gets the rpc notification and is connected, it starts
    participating in the transaction and all hell breaks loose.

    To resolve it, we should assign the peerinfo a new generation number
    everytime it's connected, so that this number will be greater than the
    generation number that the transaction is acting upon, and even though
    the peer is connected it will not participate in the transaction.

    We should also assign the new generation number of the peer to the peerctx,
    so that the framework that searches for peerinfos based on the generation
    number, will still function in the same manner.

    Removing ./tests/basic/volume-snapshot-clone.t from bad-tests.
    Also removed the duplicate entry of ./tests/bugs/snapshot/bug-1112559.t
    from bad-tests. Original entry was removed in
    http://review.gluster.org/10840

    Change-Id: I57e5efe3217abfb96733e487aea3972e116d909d
    BUG: 1224292
    Signed-off-by: Avra Sengupta <asengupt at redhat.com>
    Reviewed-on: http://review.gluster.org/10895
    Reviewed-by: Kaushal M <kaushal at redhat.com>
    Tested-by: Kaushal M <kaushal at redhat.com>
    Reviewed-on: http://review.gluster.org/10937
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p2IoJgFIAX&a=cc_unsubscribe