[Bugs] [Bug 1225491] New: [AFR-V2] - afr_final_errno() should treat op_ret > 0 also as success

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1225491

            Bug ID: 1225491
           Summary: [AFR-V2] - afr_final_errno() should treat op_ret > 0
                    also as success
           Product: GlusterFS
           Version: mainline
         Component: replicate
          Assignee: kdhananj at redhat.com
          Reporter: kdhananj at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com



Description of problem:

Figured while reading code that the function afr_final_errno() does not treat
op_ret > 0 as success.

What that means is that in inode write fops (where this function gets called by
__afr_inode_write_finalize()), op_ret could be > 0 on success. And if the inode
write fop failed on one or more subvols, there is a remote possibility that
AFR, instead of choosing the most severe errno from the set of errnos returned
by the subvolumes that saw a failure, winds up picking junk errno from the
subvol where the fop actually succeeded. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mra3ovcoNV&a=cc_unsubscribe