[Bugs] [Bug 1224611] New: Skip zero byte files when triggering signing

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1224611

            Bug ID: 1224611
           Summary: Skip zero byte files when triggering signing
           Product: GlusterFS
           Version: mainline
         Component: bitrot
          Assignee: bugs at gluster.org
          Reporter: vshankar at redhat.com
                CC: bugs at gluster.org
      Docs Contact: bugs at gluster.org



Description of problem:
commit c93c433 introduces signing of objects during write/truncate [first
modification]. This avoids signing files which were never modified after
creation.

But, bitrot daemon sapwns a filesystem crawler (one top-down scan of the
filesystem) that triggers signing of files which may have got missed in the
last run (due to disabling bitrot and other scenarios). Triggering signing does
not take into account the file size and hence triggers signing for empty files.

Fix: The "oneshot" crawler needs to take into account the file size to counter
this issue. Moreover, this check needs to be done *only* when an object has no
bitrot extended attributed (version and signature). This check is required to
handle truncates.

Although harmless, this situation can be avoided with some minor modifications.

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1. Create a Gluster volume and enable bitrot
2. create some empty files
3. before the files can be signed restart bitrot daemon

Actual results:
Empty files are signed

Expected results:
Since bitrot daemon signs files only on modification, empty files need not be
signed.

Additional info:
None

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are the Docs Contact for the bug.